segmentation fault when changing fs_game

system is ubuntu12.04

this is the gdb backtrace.

steps to reproduce:
1. start the game
2. type "fs_game abc" to console

the warsow window disappears, then it reappears, and then the game crashes.

disabling the WSW_EVDEV definition did not help.

i was able to workaround the bug by using the unix_input.c file from warsow0.62, but that does not really seem to be a proper solution :)

Why would you ever do that? You could launch the executable with fs_game, and there should be a mods menu ingame afaik...

MagusZero wrote:
Why would you ever do that? You could launch the executable with fs_game, and there should be a mods menu ingame afaik...

Yes there should be a mods menu ingame. Where is it?!
(updated 2012-08-02 23:55:18)

Well, looks like one more thing the devs missed I guess; that and mouse inversion definitely need menu options, considering how often they're used. And of course the team aspect area needs some fixing.

MagusZero wrote:
Why would you ever do that? You could launch the executable with fs_game, and there should be a mods menu ingame afaik...

thanks, but i have already found a way to work around the bug :)

I posted this, because it's possible that someone else hits this bug, who may not know how to solve it.

And btw this is also triggered, when joining a server that runs a mod...

another way to reproduce this:
1. in_restart
2. vid_restart

after in_restart the game loses mouse focus, which i think is already a known issue(?).
the crash happens after/at vid_restart.

another backtrace: http://paste.ubuntu.com/1132444/


strange thing: when using my workaround, the game still loses the mouse focus, but gets it back after vid_restart.

I've got the same issues, but when running warsow on a separate X server it doesn't crash.

So if you do that, use this simple patch to prevent the mouse from getting stuck after a modchange (it's still only stuck after in_restart as joki describes above).
(updated 2012-08-06 20:25:58)

Ok, I think I've fixed the segfault as well now. Was very straightforward with your backtrace. When input is ungrabbed the x11display.ic variable was not reset, causing focus to be set on a non-existing window.

Full patch

hettoo wrote:
Ok, I think I've fixed the segfault as well now. Was very straightforward with your backtrace. When input is ungrabbed the x11display.ic variable was not reset, causing focus to be set on a non-existing window.

Full patch

Thank you very much!
This fixes the segfault.

Now someone needs to put this into warsow 1.1 :)

Committed

Could you please apply the other part of my patch as well?
That -- suffix in the while condition causes the value of m_evdev_num to end up being -1, which causes the mouse to be stuck after an in_restart.

oops, I thought that change was rather meaningless. Will commit.

Thanks :)